Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Transactional trait for atomic DB operations #31205

Merged
merged 1 commit into from
Feb 17, 2022
Merged

Add Transactional trait for atomic DB operations #31205

merged 1 commit into from
Feb 17, 2022

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Feb 16, 2022 •
edited
Loading

@ChristophWurst ChristophWurst added this to the Nextcloud 24 milestone Feb 16, 2022
@ChristophWurst ChristophWurst self-assigned this Feb 16, 2022
@ChristophWurst ChristophWurst mentioned this pull request Feb 16, 2022
Merged
@ChristophWurst ChristophWurst added the pending documentation This pull request needs an associated documentation update label Feb 16, 2022
nickvergessen
nickvergessen approved these changes Feb 16, 2022
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM it's quite simple and might work for most places at least

@ChristophWurst ChristophWurst removed the 2. developing Work in progress label Feb 17, 2022
@ChristophWurst ChristophWurst force-pushed the enhancement/transactional-db-trait branch from 8924322 to 1d6332c Compare February 17, 2022 08:04
@ChristophWurst ChristophWurst added the 3. to review Waiting for reviews label Feb 17, 2022
@ChristophWurst ChristophWurst marked this pull request as ready for review February 17, 2022 08:04
come-nc
come-nc requested changes Feb 17, 2022
View reviewed changes
lib/public/AppFramework/Db/Transactional.php Outdated Show resolved Hide resolved
lib/public/AppFramework/Db/Transactional.php Outdated Show resolved Hide resolved
@ChristophWurst
Add Transactional trait for atomic DB operations
cb252c5 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst force-pushed the enhancement/transactional-db-trait branch from 1d6332c to cb252c5 Compare February 17, 2022 08:58
CarlSchwan
CarlSchwan approved these changes Feb 17, 2022
View reviewed changes
Copy link
Member

@CarlSchwan CarlSchwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice 👍

@ChristophWurst ChristophWurst merged commit 2db7581 into master Feb 17, 2022
@ChristophWurst ChristophWurst deleted the enhancement/transactional-db-trait branch February 17, 2022 11:48
@ChristophWurst ChristophWurst mentioned this pull request Feb 18, 2022
Merged
@ChristophWurst ChristophWurst removed the pending documentation This pull request needs an associated documentation update label Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@come-nc come-nc come-nc approved these changes

@st3iny st3iny Awaiting requested review from st3iny

@miaulalala miaulalala Awaiting requested review from miaulalala

Assignees

@ChristophWurst ChristophWurst

Labels
3. to review Waiting for reviews enhancement
Projects
None yet
Milestone
Nextcloud 24
Development

Successfully merging this pull request may close these issues.
4 participants
@ChristophWurst @nickvergessen @CarlSchwan @come-nc